QuantEcon / QuantEcon/QuantEcon.py
update discrete rv code
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.4k
- Forks
- 2.3k
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 3
Description
Now that #397 is merged, I propose that we remove the DiscreteRV class
https://github.com/QuantEcon/QuantEcon.py/blob/master/quantecon/discrete_rv.py
Not a good idea to have two sets of code for doing the same thing.
The lectures will all need to be updated accordingly, but this is a good thing, since it encourages our transition to exploiting jit compilation more thoroughly.
CC @oyamad @mmcky
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with quantecon/discrete_rv.py and identify the lectures that use DiscreteRV, then review the implementation merged in #397. Done means the duplicate DiscreteRV class is removed and all affected lectures are updated to use the remaining approach.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, content
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100