QuantConnect / QuantConnect/Lean

Precise daily end times for Oanda

Open
#8,260 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

depth feature
Dominant language
C#
Stars
21.7k
Forks
5.3k
Avg merge
2d 22h
Merged PRs (30d)
34

Description

Expected Behavior
  • Oanda CFD & Forex support precise daily end times are used if the algorithm setting is enabled
Actual Behavior
Potential Solution
  • Enable feature & assert behavior with new regression algorithms. They were originally skipped to reduce complexity given oanda data tz and exchange time zones are significantly different. Potentially there might be some improvements to be done for the FF enumerator and the Strict daily enumerator handling.
Reproducing the Problem

N/A

System Information

N/A

Checklist
  • I have completely filled out this template
  • I have confirmed that this issue exists on the current master branch
  • I have confirmed that this is not a duplicate issue by searching issues
  • I have provided detailed steps to reproduce the issue

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at Common/Util/LeanData.cs and inspect UseStrictEndTime, then trace the FF enumerator and Strict daily enumerator handling for Oanda CFD and Forex data. Enable the feature when the algorithm setting is on and add regression algorithms that assert precise daily end times, using related PRs #8254 and #8001 for context.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend, data, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.