QuantConnect / QuantConnect/Lean

[Review] DataConsolidator.DataConsolidated event

Open
#6,867 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backlog bug impact-low refactor
Dominant language
C#
Stars
21.7k
Forks
5.3k
Avg merge
2d 22h
Merged PRs (30d)
34

Description

Expected Behavior
  • Inheriting DataConsolidator works for all use cases
Actual Behavior
  • DataConsolidator.DataConsolidated is of type IBaseData which causes inheriting classes like PeriodCountConsolidatorBase to duplicate it and have to use new so that it can emit T type directly. Also they have to duplicate the OnDataConsolidated method
Potential Solution

N/A

Reproducing the Problem

N/A

System Information

N/A

Checklist
  • I have completely filled out this template
  • I have confirmed that this issue exists on the current master branch
  • I have confirmed that this is not a duplicate issue by searching issues
  • I have provided detailed steps to reproduce the issue

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating DataConsolidator and PeriodCountConsolidatorBase, then compare the DataConsolidated event with the duplicated event and OnDataConsolidated method described in the issue. Done means inheriting DataConsolidator supports the relevant use cases without redeclaring those members and can emit T directly.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.