QuTech-Delft / QuTech-Delft/netsquid-tutorial
Makefile credentials are currently hardcoded
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 1
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
Currently in the Makefile, the credentials are hardcoded to "spring26", instead of using the env variables: https://github.com/QuTech-Delft/netsquid-tutorial/blob/da527766e85955269492b0f6085cbdea52dea1b2/Makefile#L9
Above should instead be:
PIP_FLAGS = --extra-index-url=https://$(NETSQUID_USER):$(NETSQUID_PWD)@pypi.netsquid.org
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect line 9 of the Makefile and compare its PIP_FLAGS value with the issue's requested environment-variable form. Verify that NETSQUID_USER and NETSQUID_PWD are used for the package index and that the relevant Make target still invokes pip successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 88/100