QMCPACK / QMCPACK/qmcpack

SpinDensity's low memory mode is inaccessible from the application level.

Open
#6,187 0 comments 0 reactions 1 assignee Claimed by @PDoakORNL View on GitHub
Dominant language
C++
Stars
403
Forks
154
Avg merge
1d 12h
Merged PRs (30d)
82

Description

**Describe the bug**
Currently EstimatorManagerNew uses a constructor that does not correctly set data_locality based on the save_memory input. Input Testing doesn't protect this input. Also no integration testing is tripped if the correct constructor is changed. Unit testing covers the functionality but doesn't require input with this set.

**To Reproduce**
Steps to reproduce the behavior:
```

```
You would expect now there to be only one grid allocated per rank, there will still be one per crowd.

**Expected behavior**
The implemented feature to work.

**System:**
This is by inspection so I could be wrong but the test coverage is still insufficient because #6184 removed the input completely and no testing broke.

**Additional context**
Add any other context about the problem here.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.