QMCPACK / QMCPACK/qmcpack

Clean up is_closed and use H5I_INVALID_HID

Open
#5,528 1 comment 0 reactions 0 assignees View on GitHub
enhancement stale
Dominant language
C++
Stars
403
Forks
154
Avg merge
1d 13h
Merged PRs (30d)
90

Description

https://github.com/QMCPACK/qmcpack/pull/5526#discussion_r2096554038
Some thoughts. It can be better if we write a check_valid function and hide include and H5I_INVALID_HID on the cpp side.

Contributor guide

Open the contributing guide

Research direction

Start with the discussion in pull request #5526 and locate the current handling of is_closed, H5I_INVALID_HID, and the related include. Determine whether a check_valid function can replace the existing checks while keeping the include and constant on the C++ side; done means the cleanup is implemented and existing behavior remains valid.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.