QMCPACK / QMCPACK/qmcpack

create_names for timers violates DRY and has scoping issues.

Open
#5,309 2 comments 0 reactions 0 assignees View on GitHub
stale
Dominant language
C++
Stars
403
Forks
154
Avg merge
1d 12h
Merged PRs (30d)
82

Description

In the course of using detailed timers with TimerManager, there is repeated code used to connect time id enums and string labels.
This can likely be deduplicated, also the labels and enums don't need to be in global scope and should follow the current code standards. (see WalkerLogBuffer..h:130) for fix to scoping.

Since this is a facility that is fairly new and will be added to new performance critical code it would be good if the few places it is currently used it illustrated best practice.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.