Revisit Walker.h constructors
Open
Nobody has claimed this yet.
stale
- Dominant language
- C++
- Stars
- 403
- Forks
- 154
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 90
Description
Both constructors and copy constructors have variants with walker_id and parent_id as arguments.
Given there are setXXXid APIs. probably we should simplify them. See https://github.com/QMCPACK/qmcpack/pull/5063#discussion_r1657543746
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Walker.h by reviewing the constructors and copy constructors that accept walker_id and parent_id. Read the linked pull-request discussion, then compare these variants with the existing setXXXid APIs. Done means the constructor interface is simplified without losing the current ID-setting behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100