QMCPACK / QMCPACK/qmcpack

Unit testing of splined Jastrows near cutoffs distances needed

Open
#4,830 1 comment 0 reactions 0 assignees View on GitHub
stale
Dominant language
C++
Stars
403
Forks
154
Avg merge
1d 12h
Merged PRs (30d)
82

Description

Following the discussion in #4828 , better unit tests are needed for the Jastrow functions that use splines. e.g. Testing just before, at, after the cutoff values. Unit test level is needed so that sanitizer runs will catch invalid accesses. Should entail only a few extra evaluations in the existing unit tests. Not testing here led to us missing an out of bounds issue in the code.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.