QMCPACK / QMCPACK/qmcpack

Enable complex CI coeff optimization

Open
#4,820 1 comment 0 reactions 0 assignees View on GitHub
stale
Dominant language
C++
Stars
403
Forks
154
Avg merge
1d 12h
Merged PRs (30d)
82

Description

CI coefficients could be complex, and therefore we should be able to optimize both the real and imaginary parts of the coefficients.

As the code currently stands, we only optimize the real part of any ValueType parameter. In #4819, we are moving the VariableSet to be purely real, so it is the responsibility of the wavefunction component to register the real and imaginary components of a complex parameter as two reals to VariableSet. This is being implemented for RotatedSPOs and should be fixed for CI coefficients as well.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.