QMCPACK / QMCPACK/qmcpack

checkMatrix return type refinement

Open
#4,739 3 comments 0 reactions 1 assignee Claimed by @PDoakORNL View on GitHub
stale
Dominant language
C++
Stars
403
Forks
154
Avg merge
1d 12h
Merged PRs (30d)
82

Description

I saw repetitive line `CHECKED_ELSE(check.result) { FAIL(check.result_message); }` in https://github.com/QMCPACK/qmcpack/pull/4732/files

The code can be simplified by returning bool and throw error in checkMatrix instead of `{bool, string}`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.