QMCPACK / QMCPACK/qmcpack

Improve reliability of converter test error check

Open
#4,322 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
403
Forks
154
Avg merge
1d 12h
Merged PRs (30d)
82

Description

**Describe the bug**
Right now the criteria is whether the standard error file was empty or not.
On Cray machine, the MPI runner may print additional things. I think when OpenMPI is enabled with GPU, additional printout also tricked the testing.
So I feel it is better to change convert4qmc to print a completion message like QMCPACK to signal a healthy run.
The pass criteria is to see that specific line and return error code 0 from the converter run.

**Expected behavior**
Make testing easy.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.