QMCPACK / QMCPACK/qmcpack

Move QMCDriverNew::putWalkers outside of QMCDriver

Open
#4,141 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
403
Forks
154
Avg merge
1d 13h
Merged PRs (30d)
90

Description

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

The driver shouldn't know anything about the XML input. `void QMCDriverNew::putWalkers(std::vector& wset)` violates that pattern.

**Describe the solution you'd like**
A clear and concise description of what you want to happen.

Move the XML parsing outside fo QMCDriverNew

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

**Additional context**
Add any other context or screenshots about the feature request here.

Contributor guide

Open the contributing guide

Research direction

Start by locating QMCDriverNew::putWalkers and trace how XML input reaches it. Separate the XML parsing from QMCDriverNew while preserving walker setup behavior; done means the driver no longer depends on XML nodes and existing behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
hpc
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.