QMCPACK / QMCPACK/qmcpack

Give ParticleSet& W a better name

Open
#4,137 2 comments 0 reactions 1 assignee Assigned to @mdewing View on GitHub
refactor
Dominant language
C++
Stars
403
Forks
154
Avg merge
1d 12h
Merged PRs (30d)
82

Description

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

As discussed in #4127 [ParticleSet& W;](https://github.com/QMCPACK/qmcpack/blob/develop/src/QMCDrivers/WFOpt/QMCCostFunctionBase.h#L177) is a terrible variable name.

**Describe the solution you'd like**
A clear and concise description of what you want to happen.

Change it to something more descriptive. Suggestions? @PDoakORNL @ye-luo

**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.

Keep the same name, but won't improve readability.

**Additional context**
Add any other context or screenshots about the feature request here.

See #4127

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.