Where to host twist in the input?
Open
discussion
- Dominant language
- C++
- Stars
- 403
- Forks
- 154
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 82
Description
Currently MomentumEstimator looks for the twist via ParticleSet.
The twist stored in PaticleSet is set by EinsplineSetBuilder or ElectronGasOrbitalBuilder.
This way of passing information is really bad.
Instead I think it is more logical to store the twist angle information as part of boundary condition.
```
3.37316115 3.37316115 0.00000000
0.00000000 3.37316115 3.37316115
3.37316115 0.00000000 3.37316115
p p p
0.0 0.25 0.5
```
Let me know your thoughts.
Contributor guide
Assessment
This issue has not been assessed yet.