QMCPACK / QMCPACK/qmcpack

Improve accumulation of number of samples in optimizer

Open
#3,214 0 comments 1 reaction 1 assignee Claimed by @mdewing View on GitHub
enhancement optimization
Dominant language
C++
Stars
403
Forks
154
Avg merge
1d 12h
Merged PRs (30d)
82

Description

As a result of #3211, the fix in #3212 adds the global number of samples to the SampleStack class.
As suggested by Ye in the PR comments, it would be better to compute that global value by accumulating the number of samples in a manner similar to the other quantities.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.