QMCPACK / QMCPACK/qmcpack

Default DMC warmupsteps is 200 instead of 0 as documentation says

Open
#3,134 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
403
Forks
154
Avg merge
1d 12h
Merged PRs (30d)
82

Description

**Describe the bug**
When warmupsteps is not given in the input.
source code set 200 but the doc says 0.
200 is bad as it is a hidden magic number.
0 is bad if user does not diligently set a desired good value.

The ultimate way will be having warmupsteps automatically determined but this is beyond the discussion of this issue.

The purpose of this issue is to have a discussion and pick either 0 or 200. Please comment.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.