QMCPACK / QMCPACK/qmcpack

In unified drivers, migrate code out of MyDriver::process

Open
#2,710 0 comments 0 reactions 2 assignees Claimed by @PDoakORNL View on GitHub
enhancement
Dominant language
C++
Stars
403
Forks
154
Avg merge
1d 12h
Merged PRs (30d)
82

Description

Process should be factored away but it is part of the legacy interface so we can't get rid of it yet. Utimately an xmlNodePtr should not be an input argument to any method in any driver.

We want to move toward driver objects that a created as valid objects one per QMC Section and which have known data outputs that go to the constructor of the next driver.

When writing new drivers do as little as possible in process, if you do need information in the XML if it is not already parsed in a input object, make a new input object.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.