QMCPACK / QMCPACK/qmcpack

Taking WF Gradients and Laplacian computation out of updateBuffer

Open
#2,555 0 comments 1 reaction 0 assignees View on GitHub
refactor
Dominant language
C++
Stars
403
Forks
154
Avg merge
1d 12h
Merged PRs (30d)
82

Description

**Is your feature request related to a problem? Please describe.**
Current updateBuffer does both some computation and buffer operation. This is a sick design choice.

**Describe the solution you'd like**
Move all the computation of WFC G and L evaluation out of updateBuffer and put it in evaluateGL API.
Then the Kinetic evaluation is responsible for calling evaluateGL.
We have to do this change regardless how we redesign the buffer.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.