QMCPACK / QMCPACK/qmcpack

How to update the deterministic integration tests for the batched drivers

Open
#2,046 3 comments 0 reactions 0 assignees View on GitHub
testing
Dominant language
C++
Stars
403
Forks
154
Avg merge
1d 12h
Merged PRs (30d)
82

Description

This is what I found in #2043
I tried switching to the batched drivers by default to see what happens with the current deterministic integration tests. LiH dimer passes out-of-the box. However
In calculations with PBC, the non-batched driver use makeMoveAndCheck which reject moves with displacement larger than half of the box while the batched driver doesn't use check since it complicates the driver a lot and doesn't seem helpful overall. This check doesn't impact large system with big boxes but affect small system. Our existing 1 walker deterministic VMC tests have small cell and large time step and thus get affected. A safe route to me is updating current tests reference with smaller time step still based on non-batched drivers and making sure trajectors are not affected by the check. Then we switch to batched drivers without updating the reference.
Any suggestions or concerns?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.