QMCPACK / QMCPACK/qmcpack

spline2 MultiBsplines defined as PERIODIC return nonperiodic values beyond grid limit.

Open
#1,376 1 comment 0 reactions 0 assignees View on GitHub
bug discussion
Dominant language
C++
Stars
403
Forks
154
Avg merge
1d 12h
Merged PRs (30d)
82

Description

Client code should never ask for a value beyond the spline limit, but if they do the spline returns the limit value.
See
https://github.com/QMCPACK/qmcpack/blob/develop/src/spline2/MultiBsplineValue.hpp
Then look at
https://github.com/QMCPACK/qmcpack/blob/develop/src/spline2/MultiBsplineData.hpp
Splines that are not going to return values in line with their boundary conditions should throw an exception or assert.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.