QMCPACK / QMCPACK/qmcpack

sofk estimator test uses python pandas

Open
#1,273 1 comment 0 reactions 0 assignees View on GitHub
discussion
Dominant language
C++
Stars
403
Forks
154
Avg merge
1d 12h
Merged PRs (30d)
82

Description

#764 test appears to use pandas. We have to be very cautious about python dependencies and make sure the benefits are worthwhile. We should have a formal list in the documentation and README.md. For tests I would prefer the minimum number of tests since it increases the likelihood that the tests will actually be run and used. Eyeballing check_properties_h5dat.py it is for the dataframe functionality only. Can we avoid it?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.