QL-Win / QL-Win/QuickLook

Freezing when opening Pipe and Connect to check if it is running

Open
#854 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
24.7k
Forks
1.3k
Avg merge
4d 7h
Merged PRs (30d)
1

Description

Describe the bug
When I try to check if QuickLook is running I freeze it

To Reproduce
I am checking if program is running at all (Don't want to show anything yet). If it is running, this method first returns true, and second time false, because it is then frozen completely, even for Explorer

public static async Task<bool> IsQuickLookRunning()
        {
            string PipeName = "QuickLook.App.Pipe." + WindowsIdentity.GetCurrent().User?.Value;
            try
            {
                using (var client = new NamedPipeClientStream(".", PipeName, PipeDirection.Out))
                {
                    await client.ConnectAsync(500);
                }
                return true;
            }
            catch (Exception e)
            {

            }
            return false;
        }

Is there a proper way to check it?

Expected behavior
Not freeze

Desktop (please complete the following information):

  • OS Version: Windows 10 1909
  • QuickLook Version: 3.6.10 MSI

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the QuickLook.App.Pipe named-pipe handling in the QuickLook desktop application and compare it with the NamedPipeClientStream check shown in the report. Reproduce the freeze on Windows using repeated running-state checks; done means checking whether QuickLook is running no longer freezes QuickLook or Explorer and returns a reliable result.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.