QL-Win / QL-Win/QuickLook

Not working with illegal characters in path to the file.

Open
#1,197 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
24.7k
Forks
1.3k
Avg merge
4d 7h
Merged PRs (30d)
1

Description

Looking at the file Quicklook.exception.log

System.ArgumentException: Illegal characters in path.
   at System.IO.Path.CheckInvalidPathChars(String path, Boolean checkAdditional)
   at System.IO.Path.GetExtension(String path)

if this could be fixed it would be great. Seems to be because all my files are within a OneDrive folder that has 'é' in the path. I can't change this as it's work that set the name of the One Drive default name. Therefore ALL files with have that character in the path to the file!

If Quicklook could accomodate that it would be amazing. I tested it fine, once it's not on the path with illegal characters.

Thanks!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Quicklook.exception.log and reproduce opening a file whose path includes the é character in a OneDrive folder. Trace the failing path handling around System.IO.Path.GetExtension; done means QuickLook opens files from that path without raising the illegal-characters exception.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.