Q42 / Q42/NoticeWindow

Don't require super class

Open
#6 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
3
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Allow NoticeWindow to be used without requiring super class.
This makes it hard (impossible?) to work with other libraries that also require a super class (e.g. SwiftTweaks).

Suggested solution
Put all logic in a separate class that can be encapsulated in a custom UIWindow subclass.

E.g. instead of:

class MyCustomWindow : NoticeWindow {
}

Have something like:

class MyCustomWindow : ThirdPartyWindow {
  lazy var noticeWindowManager = NoticeWindowManger(window: self)
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the NoticeWindow entry point and the custom UIWindow and NoticeWindowManger examples described in the issue. Determine how the notice behavior can be exposed through a manager while allowing MyCustomWindow to inherit from ThirdPartyWindow; done means the notice component works without requiring NoticeWindow as the superclass.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.