PyThaiNLP / PyThaiNLP/pythainlp
bug: Update workflows to get triggered on "main" branch
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.2k
- Forks
- 304
- Avg merge
- 2d 14h
- Merged PRs (30d)
- 14
Description
Description
Since we have change the default branch to "main" (from "dev"),
should we need to update the workflows to get triggered on "main" too?
For pypi-publish.yml, I think we should do it from "main".
Expected results
- Unit tests and linters are running on PRs
- Package publishes correctly to PyPI
Current results
Some workflows are not running.
For example, a commit to "main" branch with a commit message "[cd build]" is not triggering the pypi-publish.yml CI for publication testing.
Steps to reproduce
Open a PR against "main" branch. No unit test is running.
PyThaiNLP version
any
Python version
any
Operating system and version
any
More info
No response
Possible solution
No response
Files
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting .github/workflows/pypi-publish.yml and the other workflow files for branch and pull-request triggers. Compare their configured branches with the repository's main branch, then verify that a pull request targeting main runs unit tests and linters and that the publication workflow responds to the documented main-branch trigger.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, python
- Domain
- ci-cd, release
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 76/100