Make it easier to combine two or more SourceCollection and TechnologyCollection objects
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 130
- Forks
- 59
- PR merge metrics
- No merged PRs in 30d
Description
During the work on the prototype of the new technology-data, it emerged the necessity to introduce SourceCollection and TechnologyCollection objects, which are currently Lists of respectively Source and Technology objects.
This issue advocates for the overriding of the __add__() method for both SourceCollection and TechnologyCollection, so that the combination of two ornmore SourceCollection objects (or two or more TechnologyCollection objects) becomes easier.
Furthermore, the current implementation of the prototype sees SourceCollection and TechnologyCollection as lists. Lists however support duplicates, which do not really make sense in this case.
Therefore, SourceCollection and TechnologyCollection should be turned to set.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the definitions and usages of SourceCollection and TechnologyCollection, then inspect how they are currently represented as lists. Check the existing test suite for collection behavior; done means both collection types can be combined and no longer allow duplicate Source or Technology objects.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100