PyPSA / PyPSA/atlite

Setting the "capacity_factor_timeseries = True" the results seem not to change

Open
#345 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

priority: low status: help wanted type: bug
Dominant language
Python
Stars
402
Forks
134
PR merge metrics
No merged PRs in 30d

Description

https://github.com/PyPSA/atlite/blob/c1e29e8ceb7b24b00e1852e5df7dd0d01a18aa82/atlite/convert.py#L128-L137

By setting the "capacity_factor_timeseries = True" the results seem not to be changed and a single generation time series is returned.
The reason might be that the flag "capacity_factor_timeseries = True" cannot be used when only a layout (no matrix and shape) is given.
I believe that line 129 is only reached if no_args = True, which means that none of layout, shapes and matrix, need to be given, in order to execute the flag.

A possible fix could be to unindending the lines: L128-L137

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with atlite/convert.py lines 128-137 and reproduce the reported behavior using a layout without a matrix or shape while setting capacity_factor_timeseries=True. Trace whether that branch is reached and compare the returned result with the expected generation time series. Done means the flag changes the result as intended for the reported input, with the existing behavior preserved for other inputs.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.