PyArray1::<bool>::as_slice is unsound
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.4k
- Forks
- 141
- Avg merge
- 16m
- Merged PRs (30d)
- 3
Description
PyArray1::<bool>::as_slice returns a &[bool], but the underlying data may not at all be valid for Rust's bool, creating instant undefined behavior. For example
>>> a = np.uint8([24, 15, 32, 1, 0]).view(bool)
>>> a
array([ True, True, True, True, False])
Calling as_slice on this from Rust reveals the invalid representation:
dbg!(arr.as_slice().unwrap());
dbg!(unsafe { core::mem::transmute::<&[bool], &[u8]>(arr.as_slice().unwrap()) });
[ false, true, false, true, false, ]
[ 24, 15, 32, 1, 0, ]
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at PyArray1::::as_slice and reproduce the issue with the provided NumPy and Rust snippets. Trace how the slice is exposed and determine how invalid bool representations must be handled. Done means as_slice no longer exposes a Rust bool slice for such data, with coverage for the demonstrated case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- numpy, rust
- Domain
- data
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100