Remove Python <3.9 fallback for `ast.Index`
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 190
- Avg merge
- 8m
- Merged PRs (30d)
- 13
Description
Hi! In SUBSCRIPT method in checker there's a dead code for checking ast.Index case which isn't reachable since 3.9 (see https://docs.python.org/3/library/ast.html) and pyflakes is currently 3.10+.
Can't submit a PR, see fix in https://github.com/Andrej730/pyflakes/tree/drop-before39-fallback / https://github.com/Andrej730/pyflakes/commit/dc2f3f0eb4b85f357abaa61e8d8019f1f87dad7f
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open pyflakes/checker.py and read the SUBSCRIPT method around the cited lines, confirming the project's Python version requirement and the unreachable ast.Index path. Run the existing checker tests after the change; done means the obsolete fallback is gone and the tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 65/100