PyCQA / PyCQA/pycodestyle

E711: Expression ending in None followed by == <other> results in incorrect

Open
#887 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
5.2k
Forks
754
PR merge metrics
No merged PRs in 30d

Description

Example:

assert x % None == tuple(1)

Results in "comparison to None should be 'if cond is None:' [E711]" even though the expression on the left is unknowable and definitely might not be None.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the example expression and trace the E711 check that reports comparisons to None. Confirm that an unknowable left-hand expression is not flagged, while valid comparisons retain the diagnostic, and add regression coverage for the reported case.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.