PyCQA / PyCQA/pycodestyle

Blank lines between methods definitions

Open
#438 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
5.2k
Forks
754
PR merge metrics
No merged PRs in 30d

Description

In pep8.py is:
"Method definitions inside a class are separeted by a single blank line"

but in https://www.python.org/dev/peps/pep-0008/ is
"Method definitions inside a class are surrounded by a single blank line."

Maybe pep8 should work in different way in same cases:

class LogsViewer(main.Main):
                                                 #<- is this line needed?
    def validate(self):
        pass

because separated != surrounded

Updated because of misunderstanding @doismellburning

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the blank-line rule in pep8.py and comparing it with the quoted wording in PEP 8. Use the LogsViewer example to determine whether a blank line before the first method should be required; the issue is done when the checker’s behavior matches the agreed interpretation.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.