PyCQA / PyCQA/pycodestyle

E713: false negatives

Open
#334 5 comments 0 reactions 1 assignee View on GitHub

@IanLee1521 is already working on this.

Since Dec 23, 2014.

Dominant language
Python
Stars
5.2k
Forks
754
PR merge metrics
No merged PRs in 30d

Description

I was looking into https://github.com/jcrocholl/pep8/issues/330, and I noticed that the following don't cause E713 when they should:

if not (X) in Y:
    pass
if not X() in Y:
    pass

Looks like the regular expression is picking up the ( between not and in and wrongly deciding that this is something of the form:

if not (X in Y or X is Z):
    pass

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.