PyCQA / PyCQA/isort

Make `_Config` and `Config` work as native class

Open
#2,629 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
7k
Forks
687
Avg merge
4h 56m
Merged PRs (30d)
2

Description

In https://github.com/PyCQA/isort/pull/2586 we opt out of making _Config and Config compiled by mypyc as that caused issues.

Let's investigate why it doesn't work and make sure it does. This might require an upstream patch in mypy to fix the underlying bug.
When we do this we can also remove the mypy-extensions dependency.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing pull request #2586 and the handling of _Config and Config in the mypyc compilation setup. Investigate the underlying mypy issue, including whether an upstream patch is needed; done means both classes work as native classes and the mypy-extensions dependency can be removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.