Remove --benchmark / --statistics / --count ?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.8k
- Forks
- 356
- PR merge metrics
- No merged PRs in 30d
Description
describe the request
did some quick profiling, flake8 -j1 spends about 5% of its time collecting these (even if they're not selected).
I also feel like these are not that useful and could probably be derived in a separate formatter if desired? I don't think I've ever used them but I've definitely broken them a few times.
what say to removing these options? (and perhaps providing a third party formatter for them as a middle-ground?)
this would also "trivially" solve #1458
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the --benchmark, --statistics, and --count options are collected and exposed when running flake8 -j1. Review the discussion around whether they should be removed or supplied by a third-party formatter, and use issue #1458 as part of the acceptance check; done means the agreed option behavior and profiling concern are addressed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli, tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100