B405 complains about any xml.etree.ElementTree import, not just parse-related ones
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 8.3k
- Forks
- 835
- Avg merge
- 5d 3h
- Merged PRs (30d)
- 1
Description
B405 complains about any xml.etree.ElementTree import, not just parse-related ones
Importing like so
from defusedxml.ElementTree import Element
gives a bandit error (B405).
This error talks about parsing (which is indeed unsafe); but the imported thing is not related to parsing. At the same time, the suggested remedy (defusedxml) exclusively provides alternatives for parsing-related functions, in particular for parse, iterparse, fromstring, and XMLParser. In other words, the suggested solution of doing the following fails:
# Will fail!
from defusedxml.ElementTree import Element
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the B405 check and its existing tests to see how xml.etree.ElementTree imports are classified. Confirm which imports are parsing-related, then update the rule and tests so non-parsing imports such as Element are not reported and the suggested defusedxml remedy applies to reported cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- security, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100