PubInv / PubInv/ADaM

Regularize the way the MQTT network is configured....

Open
#32 0 comments 0 reactions 1 assignee View on GitHub

@mohamadMZ98 is already working on this.

Since Jun 19, 2026.

Dominant language
Python
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

We want the MQTT network and password to be taken from environment variables in all cases, if we can.

Today in mobile/src/config/mqttConfig.js the password is hard-coded which is a security flaw.

In general, we have several independent tools, which I like; but they should all use the same configuration approach.

The same is true of ADaMpy/config/adam_config.json and ADamPy/simulators/manual_alarm_test.py.

The ideal think is that in each of these cases the network and password are read from the "environmennt". This should likely be set in a file called ".env" at the home directory. This file should be added to the .gitignore file so that it is not checked in.

If you are unfamiliar with these concepts you can google them or ask me.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.