ProxymanApp / ProxymanApp/Proxyman

[BUG] Crash when parsing HAR with invalid WS/WSS data

Open
#976 1 comment 0 reactions 1 assignee View on GitHub

@NghiaTranUIT is already working on this.

Since Sep 6, 2021.

✅ Done bug
Dominant language
No language data
Stars
7k
Forks
237
No merged PRs in 30d

Description

Description

Proxyman might be crashed if we parse a malformed HAR file with invalid WS/WSS data. Basically, we define WebSocket Opcode as UInt8, but the data is out of range. Therefore, the app is crashed.

Acceptance Criteria
  • Add safe check and ignore the invalid WS/WSS message

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.