ProxymanApp / ProxymanApp/Proxyman

Check the existence of onRequest/onResponse function in Scripting

Open
#748 1 comment 0 reactions 1 assignee View on GitHub

@NghiaTranUIT is already working on this.

Since Dec 31, 2020.

✅ Done enhancement
Dominant language
No language data
Stars
7k
Forks
237
No merged PRs in 30d

Description

Description

Currently, if one of those functions are absent, the console will throw an unmeaningful log

❌Error: Could not convert JSvalue to Dictionary. Please make sure the return value is a JS dictionary (Object)

We should polish it

Acceptance Criteria
  • If onRequest() or onResponse() is absent, just skip it
  • Do not throw the error if it's missing

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.