ProxymanApp / ProxymanApp/Proxyman

install-certificates-java.sh Doesn't work with JVMs installed via SDKMAN

Open
#737 12 comments 0 reactions 1 assignee View on GitHub

@NghiaTranUIT is already working on this.

Since Dec 22, 2020.

✅ Done bug
Dominant language
No language data
Stars
7k
Forks
237
PR merge metrics
No merged PRs in 30d

Description

Proxyman version? 2.15.0 (21500)
macOS Version? 10.15.7 (
Steps to reproduce
  1. Run install-certificates-java.sh
Expected behavior

Installs cert into JVM

/usr/libexec/java_home only returns JVMs installed by Mac OS. SDKMAN is a popular alternative way of installing and managing JVMs. I was able to modify install-certificates-java.sh and get this working:

home=/Users/jeremyross/.sdkman/candidates/java/current

A better solution would be to take into account /usr/libexec/java_home, SDKMAN, and probably homebrew installs as well.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.