ProxymanApp / ProxymanApp/Proxyman
Improve How we fetch the remote Certificate
Open
@NghiaTranUIT is already working on this.
Since Jul 1, 2020.
✅ Done
enhancement
- Dominant language
- No language data
- Stars
- 7k
- Forks
- 237
- PR merge metrics
- No merged PRs in 30d
Description
Description
Currently, we're using OpenSSL to fetch the remote certificate, but it doesn't work well in the following scenario:
- Support External Proxy (HTTP/HTTPS and Socks5)
- Custom Client Certificate
- Get some errors if the domain is on an internal network
- Some crashes on OpenSSL
- Hard to extend the feature since it's low-level code
It's time to refactor it and find a better alternative.
Acceptance Criteria
- Use
NIOSSLClientHandlerandNIOSSLCustomVerificationCallbackto get the Remote Certificate during Certificate Evaluation - Remove all OpenSSL and relevant code
- Test some edge cases and make sure it works
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.