ProxymanApp / ProxymanApp/Proxyman
[BUG] IP v4 is not correct for Remote Device
Open
@NghiaTranUIT is already working on this.
Since Jun 7, 2020.
bug
- Dominant language
- No language data
- Stars
- 7k
- Forks
- 237
- PR merge metrics
- No merged PRs in 30d
Description
Description
For some reason, the logic to detect the current IP v4 is not correct. It presents the different one.
A user helps us to reproduce it. The code returns two IPs and the first one is not correct.
["fe80::aede:48ff:fe00:1122%en5", "fe80::149d:ede:c70c:ae38%en7", "169.254.100.79", "fe80::52de:86dd:62dd%en0", "192.168.1.103", "2a02:1206:45a8:4bc0:66:8d84:c69b:f524", "2a02:1206:45a8:4bc0:9890:1986:89f:8abe", "fe80::106c:18ff:fe84:c44e%awdl0", "fe80::106c:18ff:fe84:c44e%llw0", "fe80::f271:6741:d751:358a%utun0", "fe80::d2c4:8e44:af5b:b3ab%utun1"]
We should fix it
Acceptance Criteria
- Improve to code to get the local IP (192.*) rather than returing the first v4
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.