ProxymanApp / ProxymanApp/Proxyman

[BUG] Couldn't generate Proxyman Certificate due to long name

Open
#458 1 comment 0 reactions 1 assignee View on GitHub

@NghiaTranUIT is already working on this.

Since Mar 29, 2020.

✅ Done bug
Dominant language
No language data
Stars
7k
Forks
237
PR merge metrics
No merged PRs in 30d

Description

Description

Thanks to Pierre to help me to get the error log when he couldn't generate the certificate on his machine.

Generating RSA private key, 2048 bit long modulus
...............................................................................................................+++++..+++++
e is 65537 (0x10001)\nproblems making Certificate Request
4702391744:error:0DFFF097:asn1 encoding routines:CRYPTO_internal:string too long:asn1/a_mbstr.c:156:maxsize=64\n"))

After investigating, it turns out that the CommonName must be lesser than 64 char. Proxyman would get the computer name and put it as a part of the Common Name. Thus, in some cases, the name is long and result in the OpenSSL error.

After he shortens the name, it works as expected 👍

Acceptance Criteria
  • Reproduce and trim the text if it's too long
  • Double-check if the name is non-ASCII char

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.