ProxymanApp / ProxymanApp/Proxyman

[BUG] App crash when setting invalid Query in Breakpoint or Scripting

Open
#2,091 1 comment 0 reactions 1 assignee View on GitHub

@NghiaTranUIT is already working on this.

Since Jul 17, 2024.

✅ Done bug
Dominant language
No language data
Stars
7k
Forks
237
PR merge metrics
No merged PRs in 30d

Description

Description

if the user sets an invalid query in the Scripting, the app will crash (AppCenter shows it)

LAST EXCEPTION BACKTRACE
CoreFoundation
__exceptionPreprocess
libobjc.A.dylib
objc_exception_throw
Foundation
-[__NSConcreteURLComponents setPercentEncodedQuery:]
Foundation
merged function signature specialization <Arg[0] = Owned To Guaranteed> of Foundation.URLComponents.scheme.setter : Swift.String?
Foundation
Foundation.URLComponents.percentEncodedQuery.setter : Swift.String?
ProxymanCore
(extension in ProxymanCore):Foundation.URL.replaceAllQueries([ProxymanCore.HeaderEntry]) -> Swift.String? URL+Utils.swift:35

Steps to Reproduce

  1. Make a Breakpoint or Scripting
  2. Set Query = name=⚡️%20Proxyman

Current Behavior

  • Crashed

Expected Behavior

  • Should decode correctly

Environment

  • App version: e.g Proxyman 5.6.1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.