ProxymanApp / ProxymanApp/Proxyman

Image preview in multpart/form-data breaks the app

Open
#1,828 9 comments 0 reactions 1 assignee View on GitHub

@NghiaTranUIT is already working on this.

Since Oct 26, 2023.

bug
Dominant language
No language data
Stars
7k
Forks
237
PR merge metrics
No merged PRs in 30d

Description

Description

When you upload a multipart request where one part is an image, ProxyMan tries to preview it (great feature btw!).
However, if the image part is not a valid image (or even if valid but maybe not supported by the preview tool you use), the app becomes unresponsive. Only "Force Quit Application" helps

Steps to Reproduce

  1. Make a regular multipart/form-data request
  2. Add a byte array part with content-type for some image (e.g. image/jpeg)
  3. Try to open "multipart" tab of the request
  4. (issue happens, app is unresponsive)

Current Behavior

Explained above, screenshot here:

image

Expected Behavior

Preview can be omitted, or an error text shown — but not the app frozen.
For me, it is enough to "export" the "part" as a file, no need for preview at all

Environment

Actually, happens for a few versions already + different macOS versions (on Sonoma too). Managed to file an issue only now :)

  • App version:Version 4.13.0 (49400)
  • macOS version: macOS Ventura 13.6 (22G120)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.