ProxymanApp / ProxymanApp/Proxyman

[BUG] Crash app when parsing Protobuf data with NaN value

Open
#1,097 3 comments 0 reactions 1 assignee View on GitHub

@NghiaTranUIT is already working on this.

Since Dec 21, 2021.

✅ Done bug
Dominant language
No language data
Stars
7k
Forks
237
No merged PRs in 30d

Description

Description

If the Protobuf content has a NaN (Not a Number) value, Proxyman will get crashed because JSONSerialization doesn't accept NaN Value. As a result, it throws the exception: NSInvalidArgumentException', reason: 'NaN number in JSON write

Acceptance Criteria
  • Fix it

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.