ProxymanApp / ProxymanApp/Proxyman

Domain automatically pinned to favorites when adding it to SSL Proxying Include List

Open
#1,053 1 comment 0 reactions 1 assignee View on GitHub

@NghiaTranUIT is already working on this.

Since Nov 2, 2021.

Dominant language
No language data
Stars
7k
Forks
237
PR merge metrics
No merged PRs in 30d

Description

Proxyman 2.34.1 (23410)
macOS Monterey 12.1 Beta (21C5021h)

Steps to reproduce
  1. Generate some HTTPS network calls to display within the main Proxyman window (I usually use a remote device)
  2. Open the SSL Proxying List Tool window
  3. Click the "+" button at the bottom of the "Include List" section
  4. Click "Add App / Domain..."
  5. Search for a domain in the previous network calls that isn't already added to the include list
  6. Select the domain listed under "Filter" and click "Add" button
  7. This should successfully add the domain to the SSL Include list but it also will automatically add it as a "Pinned" domain within the Favorites list on the main Proxyman window.

This seems like the only "SSL Include/Add domain" flow within the app that automatically pins the domain to Favorites. I tried a few others and they correctly didn't automatically add the Pin. There could be other flows that trigger this unwanted pinning behavior though.

Expected behavior

The domain should be added to SSL Include list but it shouldn't be automatically added to the Pinned Favorites list.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.