ProvableHQ / ProvableHQ/aleo-devnode
Audit buffer / block-creation lock ordering for deadlock risk
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1
- Forks
- 2
- Avg merge
- 23m
- Merged PRs (30d)
- 1
Description
Follow-up from #13 review: in src/rest/routes.rs, the buffer lock could deadlock the block-creation lock if it isn't guaranteed to be released. Audit every site that acquires either lock to confirm the ordering is safe.
Review comment: https://github.com/ProvableHQ/aleo-devnode/pull/13#discussion_r3314856262
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Begin with the review comment on pull request #13 and inspect src/rest/routes.rs. Search the repository for every site that acquires the buffer or block-creation lock, then trace the ordering at each site. Done means all acquisition sites are accounted for and the ordering is confirmed safe against deadlocks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend, distributed-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100