ProtonMail / ProtonMail/libsieve-php
Allow `requires` tag with tests.
Open
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 25
- Forks
- 9
- Avg merge
- 6m
- Merged PRs (30d)
- 3
Description
For now, it is possible to use requires inside comparators, tags, matchtype and addresspart.
The relational extension uses that for the count match type:
<matchtype name="count">
<requires type="comparator" name="i;ascii-numeric" regex="i;ascii-numeric" />
<parameter type="string" name="relation string" regex="(lt|le|eq|ge|gt|ne)" />
</matchtype>
It would be useful to be able to define a test that requires a specific field.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how requires is handled in comparators, tags, matchtype, and addresspart definitions. Compare this with the relational extension's count match type and determine how a test requiring a specific field should be represented. Done means the parser accepts that test requirement and the relevant behavior is covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100