ProtonMail / ProtonMail/WebClients
Vulnerability in Webclient
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5.6k
- Forks
- 715
- PR merge metrics
- No merged PRs in 30d
Description
While analyzing the archive extraction functionality, I found that the tar.extract() function does not properly validate hardlink targets. A malicious tar archive can create a hardlink that points to a file outside the intended extraction directory.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the tar.extract() implementation and its callers in the WebClients repository, then inspect how archive paths and hardlink targets are handled. Reproduce the reported case with a malicious archive containing a hardlink outside the extraction directory; done means the extraction rejects or safely contains that target.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100